search

postcss / postcss-safe-parser

Fault tolerant CSS parser for PostCSS
MIT License
120 stars 12 forks source link

Please use semver when you changing something #3

Closed mdreizin closed 8 years ago

mdreizin commented 8 years ago

Please use semver when you changing something.

Last 1.0.2 version introduces migration to babel 6 https://github.com/postcss/postcss-safe-parser/commit/ea4ea71607ff82566c1371fa1f9edddb330690fe and it has breaking changes.

You had to use MAJOR instead of PATCH.

mdreizin commented 8 years ago

It should be true for all postcss projects.

ai commented 8 years ago

@mdreizin how Babel 6 changes public API?

ai commented 8 years ago

If public API was changed, we should fix it.

mdreizin commented 8 years ago

@ai Yes, a lot of changes. Please see:

http://babeljs.io/blog/2015/10/29/6.0.0/ http://babeljs.io/blog/2015/10/31/setting-up-babel-6/ https://phabricator.babeljs.io

It is good practices to use MINOR or MAJOR When you changing dependencies.

mdreizin commented 8 years ago

@ai It is not good to close issue without any investigation, because your changes affect a lot of users.

ai commented 8 years ago

@mdreizin do you know, that postcss do not contain Babel in npm package. Babel is used only in development to prepare ES5 build.

All tests showed that ES5 build by Babel 6 is same that ES5 build by Babel 5.

What changes do you find in ES5 build by Babel 6?