search

postcss / postcss-simple-vars

PostCSS plugin for Sass-like variables
MIT License
415 stars 36 forks source link

test: added failing test for postcss-hexrgba plugin #100

Closed Techn1x closed 3 years ago

Techn1x commented 3 years ago

Hey! I noticed for my project when postcss-simple-vars is updated from 6.0.2 to 6.0.3, the postcss-hexrgba plugin fails to convert hex color codes to the rgba values needed.

I wrote this failing test so we can see if it's something to do with this plugin, or something awry in hexrgba.

The changes between 6.0.2 and 6.0.3 didn't look that substantial so I am not sure what broke... :thinking:

Screenshot from 2021-05-05 17-36-25

sampullman commented 3 years ago

@Techn1x Yes, it's a problem with postcss-hexrgba, the relevant issue is: https://github.com/madeleineostoja/postcss-hexrgba/issues/31

This PR fixes the issue: https://github.com/madeleineostoja/postcss-hexrgba/pull/33

Ideally it would get merged but the maintainer seems inactive. In my personal projects I'm temporarily using the above PR branch as a dependency:

"postcss-hexrgba": "github:hudochenkov/postcss-hexrgba#migrate-to-postcss-8"

Techn1x commented 3 years ago

Thanks for the quick reply! I'll give that branch a go, thanks a bunch.

ai commented 3 years ago

I am closing this PR since postcss-hexrgba must be moved to PostCSS 8. There is no way to fix it here.

Techn1x commented 2 years ago

The postcss-hexrgba was just updated to postcss 8 (v2.1.0) and the issue goes away! Thanks everyone.