Closed alansouzati closed 8 years ago
I am not sure, that we need extra options. Seems like it is issue with old one.
which option you need to add? I can work on it if you want. It seems like you want a flexible behavior to replace the value or not.
In my opinion the replace should be true by default. Anyways, I'm here to help if you are willing to provide guidelines on what you want.
I'm. Sorry, I misunderstood your PR π. Yeap, it looks find.
But I am in the train and could not release new version. So anyway you need to wait π.
You bet no rush. Thanks for being so quick to provide feedback on issues and pull requests.
hey I don't mean to bug you, but did you have a chance to look into this again?
I'm kind of dependent on this to release a new project in Grommet that uses this library.
Honesty, you should prepare that me answer will be only in Thursday. Right now I am on the conference on the river π.
As temporary solution, you can use your fork. Feel power of modularity.
I understand your pain, but look in my Twitter, and you will understand why I am unavailable π sorry
cool man, enjoy the music and the river π΅
So happy today is Thursday. #feelingHopeful π
Yeap. Thanks for pinging. I try to look today after work.
Sorry for delay :'(
you bet man, I understand you must be pretty busy. the good news is, the PR is not too big.
Ouh, I find that you do opposite thing :(. I revert this PR. Letβs continue discuss in issue.
Also always create a test in PR.
This PR aims to fix #57.
I've created a defaultVariables object which is used by definition function to check for default values. If present the default value is used, otherwise the css value is maintained.