postcss / postcss-simple-vars

PostCSS plugin for Sass-like variables
MIT License
415 stars 36 forks source link

Variables value to use default entry #58

Closed alansouzati closed 8 years ago

alansouzati commented 8 years ago

This PR aims to fix #57.

I've created a defaultVariables object which is used by definition function to check for default values. If present the default value is used, otherwise the css value is maintained.

ai commented 8 years ago

I am not sure, that we need extra options. Seems like it is issue with old one.

alansouzati commented 8 years ago

which option you need to add? I can work on it if you want. It seems like you want a flexible behavior to replace the value or not.

In my opinion the replace should be true by default. Anyways, I'm here to help if you are willing to provide guidelines on what you want.

ai commented 8 years ago

I'm. Sorry, I misunderstood your PR 😊. Yeap, it looks find.

But I am in the train and could not release new version. So anyway you need to wait 😊.

alansouzati commented 8 years ago

You bet no rush. Thanks for being so quick to provide feedback on issues and pull requests.

alansouzati commented 8 years ago

hey I don't mean to bug you, but did you have a chance to look into this again?

I'm kind of dependent on this to release a new project in Grommet that uses this library.

ai commented 8 years ago

Honesty, you should prepare that me answer will be only in Thursday. Right now I am on the conference on the river πŸ˜†.

As temporary solution, you can use your fork. Feel power of modularity.

I understand your pain, but look in my Twitter, and you will understand why I am unavailable πŸ˜† sorry

alansouzati commented 8 years ago

cool man, enjoy the music and the river 🎡

alansouzati commented 8 years ago

So happy today is Thursday. #feelingHopeful πŸ˜†

ai commented 8 years ago

Yeap. Thanks for pinging. I try to look today after work.

Sorry for delay :'(

alansouzati commented 8 years ago

you bet man, I understand you must be pretty busy. the good news is, the PR is not too big.

ai commented 8 years ago

Ouh, I find that you do opposite thing :(. I revert this PR. Let’s continue discuss in issue.

Also always create a test in PR.