search

postcss / postcss-simple-vars

PostCSS plugin for Sass-like variables
MIT License
415 stars 36 forks source link

Replace vars in define-mixin #93

Closed sampullman closed 3 years ago

sampullman commented 3 years ago

This PR resolves #92

It also refactors the plugin to use PostCSS8 visitor functions, although I notice now that this may break workflows for some people (referring to commit 794ab992f18faaa5a18ed6396df91919f8059ed9 which reverted the same type of visitor pattern usage).

This isn't really comprehensive, either. It should probably do the same for add-mixin, and possibly provide a more general mechanism for this kind of thing. It works very nicely for my use case though, and I'm happy to put some more work in to it to make it more complete.

ai commented 3 years ago

Wow, really great work.

If you want to maintain p a project, I will be happy to transfer it to you (I have too many open source projects).

ai commented 3 years ago

Released in 6.0.3.

sampullman commented 3 years ago

Thanks for merging so fast! And sure, I'd be willing to maintain this project.

ai commented 3 years ago

I send you an invite. Feel free to suggest any changes. I will double-check a few first PRs.

sampullman commented 3 years ago

Ok, sounds good. I'll work on existing issues when I have time, and perhaps add some more tests. I don't have any suggestions for features yet, so far this plugin has worked well for me.