Closed jeddy3 closed 8 years ago
14px is not a solution, it is still to small.
vertical rithm is only a addition feature, but readable text is a main feature of site ;).
I agree, try bump it up a bit. If it looks terrible on small viewports maybe we can just decrease that by a specific media query?
If it looks terrible on small viewports maybe we can just decrease that by a specific media query?
Yep, I was thinking this falls within the "minimum number of adaptions possible" category. :)
I suggest merging this in with the slightly increased font sizes as they are good for the default mobile-first styles. Adding a breakpoint and increasing the font size when the viewport is larger can be tracked in https://github.com/postcss/postcss.org/issues/145, as increasing the body font size will likely need to be accompanied by changes to the nearby elements too e.g. the heading, in a light weight, is overwhelmed by the body copy when it is at 16px.
Yup, agreed.
LGTM
Ref: https://github.com/postcss/postcss.org/issues/138
I tried 16px, but it:
a. Dramatically threw off the vertical rhythm with everything else. b. Created very short and uncomfortable line lengths on small viewports.
So, I’ve bump it to 14px, from 13px for
InANutshell
and 13px, from 12px, for `Showcase.Personally I think what we have here is a good compromise, but if it’s not acceptable then this one might need to go back to the design board.