search

postcss / postcss.org

Official website for PostCSS
https://postcss.org
MIT License
80 stars 49 forks source link

HomePage SEO Description #202

Closed awayken closed 8 years ago

awayken commented 8 years ago

Addresses #199.

thangngoc89 commented 8 years ago

There is a commented pageDescription(body) function in the top of the file. Could you also remove it ? It's from Statinamic's boilerplate.

awayken commented 8 years ago

@thangngoc89 Can you quote the line where the pageDescription(body) is? I can't see to find it.

I think you're referencing the Layout/Page/index.js file. That's not one of the files I included in this pull request. I'm not sure it quite fits the scope, but I can make the update if a member wants me to.

thangngoc89 commented 8 years ago

Ouch. Totally my bad. Looks like those LoC was removed recently.

awayken commented 8 years ago

@thangngoc89 I've updated the Twitter Summary Card tags to be compliant with Twitter's documentation.

thangngoc89 commented 8 years ago

@awayken

twitter:site - The Twitter username used by the given site including the '@' twitter:creator - The Twitter username of the individual author of the content

Many sites contain both tag with the same content. Let's wait for members' comment

awayken commented 8 years ago

@thangngoc89 We could certainly do that. I know from https://dev.twitter.com/cards/types/summary that twitter:site is required, but there's no reason we couldn't have both.

marcustisater commented 8 years ago

lgtm