postcss / postcss.org

Official website for PostCSS
https://postcss.org
MIT License
80 stars 49 forks source link

Updated statinamic 0.8 -> 0.9 #203

Closed marcustisater closed 8 years ago

marcustisater commented 8 years ago

@thangngoc89 - it says babel-register is missing. Hum...?

thangngoc89 commented 8 years ago

@MoOx npm@3 should resolve babel-register automatically right ? @marcustisater I have to admit. I didn't have a chance to update my blog to 0.9.0 so I don't know about this kind of situation. I'll investigate it.

thangngoc89 commented 8 years ago

Also, Statinamic@0.9.0 requires whatwg-fetch@0.11.0

thangngoc89 commented 8 years ago

babel-register is missing

You can work around it by using npm@3 :D

For more infomation, see https://github.com/MoOx/statinamic/issues/335

marcustisater commented 8 years ago

Sounds fair, let me know if you would you like me to add whatwg-fetch@0.11.0 & babel-register.

I thought babel-register was in core?

MoOx commented 8 years ago

Forget the babel-register thing for now, we pushed a fix as 0.9.2. For fetch, no big deal but better to upgrade.

marcustisater commented 8 years ago

Alright, cool. I'll do some fixes after work hours.

thangngoc89 commented 8 years ago

For installing npm@3 on node 4, you can see it at this line https://github.com/MoOx/statinamic/blob/2ab325c12d32b199e37488e1695313e35f9f1aea/.travis.yml#L22

peerDeps in npm@2 is frustrating.

marcustisater commented 8 years ago

Yup, let's go with npm@3

Thanks for the quick feedback.

marcustisater commented 8 years ago

Sorry, been caught up with a lot of work. I'll do the other statinamic Phenomic updates in a new pull requests.

All good for merge @thangngoc89? 😄

MoOx commented 8 years ago

Lgtm. @thangngoc89 won't be available for a few days.

marcustisater commented 8 years ago

Alright, good to know. Thanks

MoOx commented 8 years ago

:+1: