postcss / postcss.org

Official website for PostCSS
https://postcss.org
MIT License
80 stars 49 forks source link

Revision/update phenomic 0.14.0 #223

Closed halvves closed 7 years ago

halvves commented 7 years ago

Fixes #220 and is one step closer to #221

I've updated to Phenomic 0.14.0 and updated the project structure to best (with my limited knowledge) reflect structure for 0.14.0.

The project now builds/runs properly at the very least.

I have started working to get upgraded to Phenomic 0.16.2, but am running into a few problems. I will go into depth on that issue.

halvves commented 7 years ago

I'm still experiencing one error, coming from highlight.js.

/Users/halvves/dev/opensource/postcss.org/node_modules/highlight.js/styles/tomorrow.css:4
.hljs-comment {
^
SyntaxError: Unexpected token .
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:528:28)
    at Module._extensions..js (module.js:565:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/halvves/dev/opensource/postcss.org/node_modules/babel-register/lib/node.js:152:7)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at eval (eval at <anonymous> (/Users/halvves/dev/opensource/postcss.org/node_modules/.cache/phenomic/phenomic.node.bundle.js:5:29610), <anonymous>:1:18)
halvves commented 7 years ago

Just some additional information. Running in development mode (npm start) this error doesn't appear and the site spins up fine.

This error only occurs during phenomic build (npm run build). I can get phenomic build to run fine if I comment out line 3 of ./web_modules/InANutshell/index.js (importing the highlightjs theme).

MoOx commented 7 years ago

You probably need to adjust a loader scope (include/exlude pattern) to be able to consume this file as a global css thing.

marcustisater commented 7 years ago

@halvves mind looking into it? Otherwise I will try make time for it.