Closed nataliyakarat closed 7 years ago
@meuwka Thanks! Should we set async
and defer
to true
(at least official docs tell about it, but I not sure will it works with React)?
@meuwka Travis CI reported about SyntaxError: Unexpected token .
. Do you have it locally? Or it is problem in tests?
Other tricky question. Should we change default color of this button?
@meuwka how it looks right now? Is it green as in official docs? Is it hard to change it to brand red (#dd3a0a
)?
@marcustisater do you think that brand red will be the best for this button?
@ai Hi! Travis CI reported this issue in master also. Problem is in highlight.js
file
I'm not sure about defer
(old browsers) but 'async' probably we should use because script is embedding in <head >
I set undefined
value because it's way from docs react-helmet
(when attribute takes no value)
Yea, button is green, we also can create our own button. Sidecar has activationElement
in options. Or just set color
Great :). I think we could merge even green version of it.
Letβs wait for @marcustisater review. I think it could take few hours. So if you have time you could make button red in current PR :).
@meuwka great! Thanks for you work :).
@marcustisater ping me when you deploy it :)
@ai thanks :)
You are correct, the error is from highlight.js
and not from this PR. I will create separate issue for that.
This PR LGTM, good work @meuwka ππ
@ai It's live now but appcache so it might take a while π
Add code from https://sidecar.gitter.im/ through
react-helmet