search

postcss / postcss.org

Official website for PostCSS
https://postcss.org
MIT License
80 stars 49 forks source link

Add Gitter button #227

Closed nataliyakarat closed 7 years ago

nataliyakarat commented 7 years ago

Add code from https://sidecar.gitter.im/ through react-helmet

ai commented 7 years ago

@meuwka Thanks! Should we set async and defer to true (at least official docs tell about it, but I not sure will it works with React)?

ai commented 7 years ago

@meuwka Travis CI reported about SyntaxError: Unexpected token .. Do you have it locally? Or it is problem in tests?

ai commented 7 years ago

Other tricky question. Should we change default color of this button?

@meuwka how it looks right now? Is it green as in official docs? Is it hard to change it to brand red (#dd3a0a)?

@marcustisater do you think that brand red will be the best for this button?

nataliyakarat commented 7 years ago

@ai Hi! Travis CI reported this issue in master also. Problem is in highlight.js file

I'm not sure about defer (old browsers) but 'async' probably we should use because script is embedding in <head > I set undefined value because it's way from docs react-helmet (when attribute takes no value)

Yea, button is green, we also can create our own button. Sidecar has activationElement in options. Or just set color

ai commented 7 years ago

Great :). I think we could merge even green version of it.

Let’s wait for @marcustisater review. I think it could take few hours. So if you have time you could make button red in current PR :).

ai commented 7 years ago

@meuwka great! Thanks for you work :).

@marcustisater ping me when you deploy it :)

nataliyakarat commented 7 years ago

@ai thanks :)

marcustisater commented 7 years ago

You are correct, the error is from highlight.js and not from this PR. I will create separate issue for that.

This PR LGTM, good work @meuwka 🎉😄

marcustisater commented 7 years ago

@ai It's live now but appcache so it might take a while 😅