search

postcss / postcss.org

Official website for PostCSS
https://postcss.org
MIT License
80 stars 49 forks source link

Use postcss-preset-env instead of cssnext #239 #240

Closed ur300 closed 6 years ago

ur300 commented 6 years ago

postcss-preset-env added to the main page instead of cssnext

ai commented 6 years ago

@ur300 it is always better to mention main maintainer in New pull request

/cc @marcustisater

marcustisater commented 6 years ago

Thanks for PR @ur300 👍Remember to reference the issue next time. Let me look through code and copy.

marcustisater commented 6 years ago

Whops sorry my fault @ur300. You did reference it in the title 😄

Code looks good but I think the SVG should have a set height and width with correct viewbox like https://github.com/postcss/postcss.org/blob/master/web_modules/InANutshell/css-modules.svg has. Would you mind fixing that? That would be awesome!

On the other hand I think the order should be like before, so

  1. Autoprefixer.
  2. Preset Env
  3. CSS Modules
  4. Stylelint
  5. LostGrid

@ai @jonathantneal is the copy ok? See attacthed screenshot.

order

ai commented 6 years ago

Yeap. Let's more Preset Env to second position.

And let's remove pv- from media query name to make it simpler.

jonathantneal commented 6 years ago

This all seems good to me.

ur300 commented 6 years ago

hi @marcustisater, thanks for review. all the fixes are done - svg size, margin, order of features, media query name.

ai commented 6 years ago

@ur300 task is marked as solved by you https://cultofmartians.com/tasks/postcss-preset-env-postcss.html

jonathantneal commented 6 years ago

@ai, sweet, is this being merged today?

ai commented 6 years ago

We waiting for @marcustisater review and deploy

marcustisater commented 6 years ago

SVG viewbox is still odd, but I can fix it later. LGTM

marcustisater commented 6 years ago

@ai @jonathantneal bah, something is wrong with deploy 😢 I think it has something to do with the node env or when we switched over to HTTPS. Let me check tonight. Sorry for troubles! I will let you know when it's fixed.

marcustisater commented 6 years ago

@ai @jonathantneal I deployed from local env, should be up live now 😄 I will add new issue for auto deploy trouble. 😓