Closed ur300 closed 6 years ago
@ur300 it is always better to mention main maintainer in New pull request
/cc @marcustisater
Thanks for PR @ur300 ๐Remember to reference the issue next time. Let me look through code and copy.
Whops sorry my fault @ur300. You did reference it in the title ๐
Code looks good but I think the SVG should have a set height and width with correct viewbox like https://github.com/postcss/postcss.org/blob/master/web_modules/InANutshell/css-modules.svg has. Would you mind fixing that? That would be awesome!
On the other hand I think the order should be like before, so
@ai @jonathantneal is the copy ok? See attacthed screenshot.
Yeap. Let's more Preset Env to second position.
And let's remove pv-
from media query name to make it simpler.
This all seems good to me.
hi @marcustisater, thanks for review. all the fixes are done - svg size, margin, order of features, media query name.
@ur300 task is marked as solved by you https://cultofmartians.com/tasks/postcss-preset-env-postcss.html
@ai, sweet, is this being merged today?
We waiting for @marcustisater review and deploy
SVG viewbox is still odd, but I can fix it later. LGTM
@ai @jonathantneal bah, something is wrong with deploy ๐ข I think it has something to do with the node env or when we switched over to HTTPS. Let me check tonight. Sorry for troubles! I will let you know when it's fixed.
@ai @jonathantneal I deployed from local env, should be up live now ๐ I will add new issue for auto deploy trouble. ๐
postcss-preset-env added to the main page instead of cssnext