Closed ai closed 4 years ago
@okonet are you OK with a font number reducing? Now Fire Sans only to improve performance.
@marcustisater do we right now deploy to GitHub Pages or to Netlify?
Looking good!
WOW! Nice job @ai 😍
I love the performance results.
You decide if we use GitHub Pages or Netlify. Netlify gave us free plan to use. It will auto trigger the deploy on push to master
branch. It runs npm run build
and publish dist
dir. Should I change build steps to anything else?
@marcustisater what do we use right now? Netlify is nice, but have problem with banning in Russian. But right now postcss.org is not banned.
@ai ok, interesting. Yes, we use Netlify today. Domain is pointed to Netlifys DNS.
@ai if you want I can look into https://docs.netlify.com/domains-https/netlify-dns/#ipv6-traffic
In this case let's continue to use Netlify.
I will update PR (and add the config for better caching).
Great, let me know when you are ready and if I need to change any build configs in Netlify 🥳
@marcustisater can you add me to Netlify? Or set NODE_ENV=production
in Settings > Build & deploy > Environment > Environment variables
?
Netlify build is not working in the PR because Netlify refuses to call yarn install --production
for some reason (do we override NODE_ENV
in settings?).
I invited andrey@sitnik.ru to Netlify. Changed NODE_ENV but it didn't help. I will help you debug.
I see you found out why it's not working. We are using gh-pages 😂 🙈
@ai did gh-pages auto deploy? I am so sorry I confused things...
I made an auto-deploy via Travis CI
I think we need to delete Netlify project to avoid confusion is the future :)
I just deleted it. Great with auto deploy. I think it's also good idea to remove LGTM. I will delete old branches too.
Thanks for cleaning things up 😅
master
Before
After
Results