search

postcss / sugarss

Indent-based CSS syntax for PostCSS
MIT License
710 stars 39 forks source link

Possible outdated information in the docs #97

Closed vitalybaev closed 1 year ago

vitalybaev commented 2 years ago

In readme, I've found the following paragraph:

postcss-import doesn’t support .sss file extension, because this plugin implements W3C specification. If you want smarter @import, you should use postcss-easy-import with the extensions option.

But it seems that postcss-import supports SugarSS normally, doesn't it?

ai commented 2 years ago

Sorry, I do not use postcss-import. Can you make a research?

vitalybaev commented 2 years ago

I left the link to the sources, where you can see handling .sss files. Here is the link again:

https://github.com/postcss/postcss-import/blob/master/lib/process-content.js#L21-L30

I also noticed that imports work with postcss-import when I was implementing SugarSS support in Vite.

ai commented 2 years ago

Let’s remove the note if it is not actual anymore. Did you try sugarss and postcss-import in practice?

If yes, send PR with comment removing.

vitalybaev commented 2 years ago

Yes, I tried this with tests in Vite project

https://github.com/vitejs/vite/pull/6705/files#diff-049fcac4d2cafccb313577d936c10b30ccc7f54ac3d3c3043114f068ad7133b2

So, it works correctly with .sss files as well. I'll send a PR with fix later