Define unit tests for peer discovery without internet

postech-dao / simperby

The ultimate BFT blockchain engine for decentralized organizations with powerful trustless interoperability.

MIT License

72 stars 38 forks source link

Define unit tests for peer discovery without internet #11

Open junha1 opened 2 years ago

f2koi commented 2 years ago

It seems we have two options when running the tests on the same machine:

to create multiple r/w streams in the same (OS) process and let them communicate with each other
to create a single r/w stream in the binary but spawn multiple processes to have separated nodes

The first choice is easier to code, however, the second one is more desirable since we can have logically separated nodes, which resemble the nodes in a local private network.

junha1 commented 2 years ago

I think we will have bunch of e2e tests that covers the second options. Let's stick to the first one so that we can focus on the 'logic', not the lower level network issues.

f2koi commented 2 years ago

Basic tests for bootstrapping are included in #41. I plan to add more tests for continuous peer discovery.

f2koi commented 2 years ago

The interface for the network module has been changed. Thus, the network developers(including me) should make new unit tests for the new interface.