github-actions[bot]
commented
9 months ago Pull Request Test Coverage Report for Build 7207008932
- 17 of 24 (70.83%) changed or added relevant lines in 4 files are covered.
- 11 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-2.2%) to 76.42%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| internal/servicecheck/transport.go | 0 | 1 | 0.0% | ||
| internal/kubenurse/server.go | 10 | 16 | 62.5% | ||
| <!-- | Total: | 17 | 24 | 70.83% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| internal/servicecheck/servicecheck.go | 4 | 86.58% | ||
| internal/kubediscovery/nodewatcher.go | 7 | 78.43% | ||
| <!-- | Total: | 11 | --> |
| Totals | |
|---|---|
| Change from base Build 7198416239: | -2.2% |
| Covered Lines: | 444 |
| Relevant Lines: | 581 |
I noticed that kubenurse was:
SIGTERMthen the http server shuts down almost immediately).In Kubenurse shutdown scenarios, this lead to erroneous
me_ingresserrors (i.e. when the pod has already closed its http server, but the ingress-nginx still has an inflight request that then timeouts), and to to falsepath_<node>errors as well, as terminating pods were still receiving queries.together with that I fixed the build script a little 🙃