postfinance / kubenurse

Kubernetes network monitoring
MIT License
407 stars 39 forks source link

fix: do not reuse connections per default #105

Closed clementnuss closed 8 months ago

clementnuss commented 8 months ago

stop reusing connections per default, by modifying the http.Transport DisableKeepAlive field to true per default. Can be overriden through setting KUBENURSE_REUSE_CONNECTIONS env var to "true"

This will be a minor change, as the results and behaviour of Kubenurse is modified consequently.

clementnuss commented 8 months ago

@zbindenren @djboris9 what do you think ?

the effect on the number of open file descriptor/goroutines is really interesting. the http request duration also starts to be more interesting !

do you agree that this mode should be the default ?

image
github-actions[bot] commented 8 months ago

Pull Request Test Coverage Report for Build 7584865362


Totals Coverage Status
Change from base Build 7382603208: -0.3%
Covered Lines: 467
Relevant Lines: 609

💛 - Coveralls
zbindenren commented 8 months ago

@zbindenren @djboris9 what do you think ?

the effect on the number of open file descriptor/goroutines is really interesting. the http request duration also starts to be more interesting !

do you agree that this mode should be the default ?

image

@clementnuss LGTM 👍