Add helm chart - Githubissues

postfinance / kubenurse

Kubernetes network monitoring

MIT License

416 stars 39 forks source link

Add helm chart #24

Closed bramvdklinkenberg closed 3 years ago

bramvdklinkenberg commented 3 years ago

This PR implements:

A helm chart to deploy kubenurse
A helm lint workflow
Documentation about the helm chart

bramvdklinkenberg commented 3 years ago

I need some help with this, the ci workflow fails on my own branch. It fails on the GoReleaser step, but I have clue of what is going wrong.

zbindenren commented 3 years ago

@bramvdklinkenberg the ci workflow is now fixed. Please rebase with master.

Would be great if you update the ci worklfow to deploy the helm chart (similar to the kustomize version) to another namespace and perform the same checks. That would be awesome.

bramvdklinkenberg commented 3 years ago

@bramvdklinkenberg the ci workflow is now fixed. Please rebase with master.

Would be great if you update the ci worklfow to deploy the helm chart (similar to the kustomize version) to another namespace and perform the same checks. That would be awesome.

Hi @zbindenren , I rebased and pushed it to my local branch. Do you want me to add the helm deployment in the ci workflow via this PR? And you want the helm deployment done next to the kustomize one? I was also thinking of creating a new PR after this one for creating a helm repo.

zbindenren commented 3 years ago

@bramvdklinkenberg the ci workflow is now fixed. Please rebase with master. Would be great if you update the ci worklfow to deploy the helm chart (similar to the kustomize version) to another namespace and perform the same checks. That would be awesome.

Hi @zbindenren , I rebased and pushed it to my local branch. Do you want me to add the helm deployment in the ci workflow via this PR? And you want the helm deployment done next to the kustomize one? I was also thinking of creating a new PR after this one for creating a helm repo.

@bramvdklinkenberg yes that would be great if you include the helm ci integration tests. You should probably create an new namespace in the ci and deploy the helm chart similiar to the kustomize version in that namespace.

Otherwise I have to checkout the branch and test it myself :-)

bramvdklinkenberg commented 3 years ago

Hi @zbindenren , I added an extra workflow to deploy the helm chart to a kind cluster. Took me a while because I did something wrong with the extraEnv templating in the daemonset and didn't see it right away. That is fixed now. The workflows succeeded on my own branch

bramvdklinkenberg commented 3 years ago

You will merge it I think @zbindenren? Once it is merged I will create a new PR to create a helm repo.

zbindenren commented 3 years ago

Thank you.