postfinance / kubenurse

Kubernetes network monitoring
MIT License
407 stars 39 forks source link

feat: expose metrics from the kubenurse httpclient #31

Closed ghouscht closed 2 years ago

ghouscht commented 2 years ago

The following new metrics were added:

To discuss: Maybe we should make the httpclient_trace_request_duration_seconds metrics an opt-in feature, because it adds quite a lot of new metric series:

= 96 time series added!

Another solution would be to split the httpclient_trace_request_duration_seconds histogram into multiple histograms to be able to use more granular buckets. For example the dns_start/done part should be very fast, so there is no need for the .25, .5, 1 buckets.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1676578814


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/servicecheck/transport.go 8 29 27.59%
internal/servicecheck/httptrace.go 47 70 67.14%
<!-- Total: 74 118 62.71% -->
Totals Coverage Status
Change from base Build 1662046263: -1.9%
Covered Lines: 415
Relevant Lines: 525

💛 - Coveralls