search

postfinance / kubenurse

Kubernetes network monitoring
MIT License
407 stars 39 forks source link

Upload Helm chart for Traefik ingress version 2.x with subpath #38

Closed eli-halych closed 9 months ago

eli-halych commented 2 years ago

Signed-off-by: eli.halych@gmail.com eli.halych@gmail.com

Old chart folder renamed to: kubenurse_nginx New chart folder renamed to: kubenurse_traefik_v2_subpath

Needs a change in the pipeline workflow to pass the check.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1864932580

Totals Coverage Status
Change from base Build 1859202238: 0.0%
Covered Lines: 421
Relevant Lines: 531
💛 - Coveralls
djboris9 commented 2 years ago

Hi @eli-halych

Thanks for your PR and sorry for the late answer!

The problem is our CI job. It is made for ingress-nginx and isn't suitable for Traefik. To solve this I'm currently trying to refactor the CI job in branch https://github.com/postfinance/kubenurse/tree/ci-traefik so it will have a job with an nginx and one with traefik, reusing the check procedure.

If this works, we can use one single helm chart for kubenurse and add support for Traefik directly into it, without having two separate charts.

djboris9 commented 2 years ago

With #39 I prepared a CI workflow that includes Traefik v2.

What I don't understand is the use of Middlewares like strip-add-alive and not using only IngressRoute. Is this solely made to be able to use subpaths in routing instead of DNS names? Like you've written in https://github.com/postfinance/kubenurse/issues/33#issuecomment-1044628224

If this is the case, I would rather add a switch to the kubenurse helm chart to select traefik and an option to pass the subpath. This way we can have only one helm chart which fits to Traefik and nginx.

clementnuss commented 9 months ago

salut @eli-halych thanks for your PR! I won't however merge it as it is standing right now, because:

can you elaborate on why those are needed and what do they do ?

also, I don't understand why custom CRDs are needed to deploy a simple Ingress endpoint.

I would be more interested in seeing an HTTPRoute(from the upstream Gateway API initiative) PR, configurable through a flag in values.yaml. I hope it makes sense 🙃