Add additional Helm Configuration options

postfinance / kubenurse

Kubernetes network monitoring

MIT License

407 stars 39 forks source link

Add additional Helm Configuration options #42

Closed domi2120 closed 2 years ago

domi2120 commented 2 years ago

To increase the flexibility of the helm chart, this pull request adds several additional configuration options:

support for an optional ServiceMonitor.
additional pod labels/annotations.
pod and container securityContexts.
additional labels on the service.
custom tolerations (or to remove the default tolerations).use release name insteaduse release name instead

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2422468185

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 80.603%

Totals
Change from base Build 2344683670:	1.3%
Covered Lines:	428
Relevant Lines:	531

💛 - Coveralls

djboris9 commented 2 years ago

Hi @domi2120

Thanks for your PR! It looks good to me

I've requested only a few minor spelling issues for a more consistent readme document. If you could incorporate these or just make the lower and uppercase more consistent, I would appreciate it.

And it also implements the part from https://github.com/postfinance/kubenurse/issues/35#issuecomment-1124926541 .

domi2120 commented 2 years ago

Hi @djboris9 thank you for the quick response, I've adjusted the spelling as requested.

djboris9 commented 2 years ago

Thanks for your contribution :100: