postfinance / kubenurse

Kubernetes network monitoring
MIT License
416 stars 39 forks source link

configurable histogram buckets #59

Closed myaser closed 10 months ago

myaser commented 1 year ago

I found the default buckets of Prometheus to be collecting too much data and filling up the disk quickly. Added an environment variable to adjust the buckets as needed

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3949292548


Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/kubenurse/server.go 7 17 41.18%
<!-- Total: 9 19 47.37% -->
Totals Coverage Status
Change from base Build 3638401499: -1.2%
Covered Lines: 448
Relevant Lines: 576

💛 - Coveralls
clementnuss commented 11 months ago

thanks for the PR. could you rebase/merge my updates please ? will review it afterwards

clementnuss commented 10 months ago

finally! @myaser you'll be able to use your functionality, sorry it took so long