search

postfinance / kuota-calc

Simple utility to calculate the resource quota needed for your k8s deployment(s)
MIT License
24 stars 4 forks source link

Support to additional kinds, error handling in case IsNotRegisteredError #10

Closed lzecca78 closed 2 years ago

lzecca78 commented 2 years ago

Hi! the current PR will introduce the following kinds:

On top of that, I've handled the cases in which the resources present in the yaml are not registered, and instead of failing, it raises an error.

lzecca78 commented 2 years ago

hi @ghouscht, I saw that is failing the linter, I fix it asap. The one if failing about the test is because it is using golang 1.15, while I've updated the golang version (and all the libraries) to golang 1.17. In the latest commit, I've fix the lining (hopefully) and forced the action/setup-go to use the golang 1.17 version

ghouscht commented 2 years ago

hi @ghouscht, I saw that is failing the linter, I fix it asap. The one if failing about the test is because it is using golang 1.15, while I've updated the golang version (and all the libraries) to golang 1.17. In the latest commit, I've fix the lining (hopefully) and forced the action/setup-go to use the golang 1.17 version

That's ok, thank you. Will review the changes later on today.