Closed saibaldey closed 5 years ago
Hi @saibaldey Thank you for your pull request. Everything looks fine, please just change the URL to hide real hostnames (see review comment). Then I will merge this
Have made the required changes. Please approve & merge.
Updated the readme with details on how to fix two issues related to the vault-kubernetes-synchronizer. No code changes were required, only added the guide to fix few configuration hurdles. Hope this would enhance the usages on this. I had to debug the go codebase to finally find the bug in my configuration. Had this been added to the readme, that would have saved my 1 week of effort.