postfixadmin / docker

Docker Image for PostfixAdmin
https://hub.docker.com/_/postfixadmin
GNU General Public License v2.0
73 stars 21 forks source link

Add support for Docker secrets #31

Closed mathieupotier closed 3 years ago

mathieupotier commented 3 years ago

Add support for docker secrets : https://docs.docker.com/engine/swarm/secrets/

Created new environment var to manage secrets source files.

Hope it helps, made such a change for my usage, and seems working perfectly ^_^

J0WI commented 3 years ago

I'd prefer to use the same pattern as other php images do. Would you like to implement this?

mathieupotier commented 3 years ago

I can do it, I'll push this in few hours.

mathieupotier commented 3 years ago

Done.

I just prefered to not export env var to avoid leaks on secrets. The replaced env vars are just shared under current PID, they don't go to the kernel stack.