search

postfixadmin / docker

Docker Image for PostfixAdmin
https://hub.docker.com/_/postfixadmin
GNU General Public License v2.0
73 stars 21 forks source link

Added support for $CONF['encrypt'] with POSTFIXADMIN_PASSWD_ENCRYPTION #44

Closed BOFH90 closed 3 years ago

BOFH90 commented 3 years ago

Added the environment variable for this Issue: https://github.com/postfixadmin/docker/issues/20

DavidGoodwin commented 3 years ago

I'd almost prefer it that your new env var ( POSTFIXADMIN_PASSWD_ENCRYPTION ) was called POSTFIXADMIN_ENCRYPT - 'cos at least then there's a direct mapping to the $CONF variable name, but I can see why you chose a different name.

Alternatively, we look at some way of having a directory of config file(s) that can be added in - so rather than needing to support 101 environment variables, you just mount PHP config file(s) into the container?

BOFH90 commented 3 years ago

Sure, I can rename the env var to "POSTFIXADMIN_ENCRYPT" if you´d like to. Your suggestion to add config-files also sounds fine to me.

BOFH90 commented 3 years ago

UPDATED: Changed env var name to POSTFIXADMIN_ENCRYPT

DavidGoodwin commented 3 years ago

Thanks for the PR - sorry - I've not been paying attention to the 'docker' repo - so this has sat unloved for a short while.

Anyway - looks good to me.....