search

postgis / docker-postgis

Docker image for PostGIS
https://hub.docker.com/r/postgis/postgis/
MIT License
1.37k stars 462 forks source link

make update 2021-Aug-19 #253

Closed ImreSamu closed 3 years ago

ImreSamu commented 3 years ago
df7cb commented 3 years ago 
Date: Fri, 20 Aug 2021 13:12:46 +0200
From: Christoph Berg <myon@debian.org>
To: Imre Samu <pella.samu@gmail.com>
Cc: pgsql-pkg-debian@lists.postgresql.org
Subject: Re: postgresql-14-postgis-3-scripts has not been updated to 3.1.3 ?

Re: Imre Samu
> I am trying to update https://github.com/postgis/docker-postgis project  to
> the latest PostGIS 3.1.3
> with https://github.com/postgis/docker-postgis/pull/253
> and receiving this error :
>        *Error:  E: Version '3.1.3+dfsg-1~exp1.pgdg100+1+b1' for
> 'postgresql-14-postgis-3-scripts' was not found*
>
> as I see the - the postgresql-14-postgis-3-scripts  is still on 3.1.2
> *   postgresql-14-postgis-3-scripts/buster-pgdg 3.1.2+dfsg-1~exp2.pgdg100+1

Hi,

thanks for spotting that.

The problem arose because a new postgis version, me working on
supporting PG 14, and adding new distributions (impish, bookworm) all
happened at the same time. Add the necessity for a +b1 binNMU to the
mix, and the result was that the architecture _all .deb files for PG14
were never built.

Our repository QA scripts didn't catch that because
postgresql-14-postgis-3 depends on postgresql-14-postgis-3-scripts
without a version constraint, so everything was still installable.

It's fixed now, but you'll still need to update the Dockerfile as the
-scripts package doesn't have the +b1 suffix since it's arch:all.
(Why is the version hard-coded there anyway?)

Christoph
ImreSamu commented 3 years ago

@df7cb: Thank you for your help!

// Linking related pgsql-pkg-debian thread

@phillipross :
Ready for review. I have selected the simplest solution - and removed the " -scripts" versioning - in the Dockerfile.template

-           postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR-scripts=$POSTGIS_VERSION \
+           postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR-scripts \

but if you have a better solution - just drop my PR ..

phillipross commented 3 years ago

I actually don't have a better solution for it. I'll have to look a little closer, but it seems like it shouldn't be an issue. I can't foresee a situation where we'd need to be able to explicitly specify a version of that package in normal circumstances. And, well, if the situation does arise... we can work around it 😃

phillipross commented 3 years ago

The most recent build of the master branch failed due to what looks like packaging changes, so I'll rerun CI on this PR and if it is successful, I'll go ahead and merge it.