postgis / docker-postgis

Docker image for PostGIS
https://hub.docker.com/r/postgis/postgis/
MIT License
1.39k stars 466 forks source link

add ca-certificates: for accessing remote raster files; #311

Closed ImreSamu closed 2 years ago

ImreSamu commented 2 years ago

fix: https://github.com/postgis/docker-postgis/issues/307

important changes:

based on my local test; minimal disk space increase is expected ( < 1MB )

# debian
new_postgis                                       14-3.2               77ce6bebee3d   20 seconds ago   575MB
postgis/postgis                                   14-3.2               9791b51b1ff7   4 days ago       575MB

# alpine
new_postgis                                       14-3.2-alpine        c18a9d1d4d26   3 minutes ago    395MB
postgis/postgis                                   14-3.2-alpine        128949707ecd   4 days ago       395MB

# master  - not tested .. disk space is less important.

disclaimer: remote raster file access not tested;

IMHO: if the CI/CD is OK then ready to review/merge.

ImreSamu commented 2 years ago

maybe i'm missing it, but in the master tenmplates it seems in cases where the ca-certificates package is not found to be installed, there's no explicit installation. I'm not understanding the reason for the removal of the explicit ca-certificates package from the master templates.

this is the "original" Dockerifle.master.templete ... ( search for 'ca-certificates' )

this is the proposed "new" Dockerfile.master.template:

And the 'ca-certificates' is installed in both of the "stage" ( we are using "multi-stage builds" )

in my proposal:
I have

phillipross commented 2 years ago

oops, I see now. I was definitely reading incorrectly 😅 looks good and thanks for the clarifications!