search

postgis / docker-postgis

Docker image for PostGIS
https://hub.docker.com/r/postgis/postgis/
MIT License
1.39k stars 466 forks source link

create TEST image for Pg17 #386

Closed thomasboussekey closed 3 months ago

coderabbitai[bot] commented 3 months ago
Walkthrough ## Walkthrough The changes introduce a robust multi-stage Docker build process for creating a PostgreSQL image with enhanced PostGIS extensions. Key dependencies and libraries are installed, along with scripts for initializing and updating PostGIS within PostgreSQL databases. These improvements streamline the setup and maintenance of spatial database environments, ensuring a smoother experience for users. ## Changes | File | Change Summary | |------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `17-beta/Dockerfile` | Implements a multi-stage build process based on `postgres:17beta2-alpine3.20`, installing dependencies and building libraries like CGAL, SFCGAL, PROJ, GEOS, and PostGIS. | | `17-beta/initdb-postgis.sh` | Introduces a script to automate the creation of a `template_postgis` database and load PostGIS extensions into specified databases. | | `17-beta/update-postgis.sh` | Adds a script that updates PostGIS extensions in specified databases, managing PostGIS and its dependencies effectively. | | `17beta2-3.5.0alpha2/alpine/Dockerfile` | Configures a Docker image for PostGIS 3.5.0alpha2 on Alpine Linux, including dependency installation, building PostGIS, and copying initialization scripts. | | `README.md` | Updates versioning information and adds new Docker image entries for PostGIS. | | `update.sh` | Introduces new entries for additional versions in associative arrays without altering existing logic. | | `12-3.4/alpine/Dockerfile` | Updates base image from `postgres:12-alpine3.18` to `postgres:12-alpine3.20`. | | `13-3.4/alpine/Dockerfile` | Updates base image from `postgres:13-alpine3.18` to `postgres:13-alpine3.20`. | | `14-3.4/alpine/Dockerfile` | Updates base image from `postgres:14-alpine3.18` to `postgres:14-alpine3.20`. | | `15-3.4/alpine/Dockerfile` | Updates base image from `postgres:15-alpine3.18` to `postgres:15-alpine3.20`. | | `16-3.4/alpine/Dockerfile` | Updates base image from `postgres:16-alpine3.18` to `postgres:16-alpine3.20`. | | `16-3.5.0alpha2/alpine/Dockerfile` | Introduces a new Dockerfile for PostGIS 3.5.0alpha2 with PostgreSQL 16 on Alpine, including relevant metadata and scripts. | | `Dockerfile.alpine.template` | Modifies the base image to `postgres:%%PG_MAJOR%%-alpine3.20` for a PostgreSQL setup template. | ## Poem > In the Docker depths, PostGIS lights, > PostgreSQL gains new heights. > Scripts to set the GIS scene, > Update, setup, all pristine. > Dependencies built with care, > Now your data’s everywhere! 🐇🌍
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 8a0cbf9bcc303e990d0bca4e35c813fd0b4f3071 and 42d811c4d0e15c4ea6c99413f61b8713932a3e4e.
Files selected for processing (10) * 12-3.4/alpine/Dockerfile (1 hunks) * 13-3.4/alpine/Dockerfile (1 hunks) * 14-3.4/alpine/Dockerfile (1 hunks) * 15-3.4/alpine/Dockerfile (1 hunks) * 16-3.4/alpine/Dockerfile (1 hunks) * 16-3.5.0alpha2/alpine/Dockerfile (1 hunks) * 17beta2-3.5.0alpha2/alpine/Dockerfile (1 hunks) * Dockerfile.alpine.template (1 hunks) * README.md (2 hunks) * update.sh (3 hunks)
Files skipped from review due to trivial changes (4) * 12-3.4/alpine/Dockerfile * 13-3.4/alpine/Dockerfile * 14-3.4/alpine/Dockerfile * 16-3.4/alpine/Dockerfile
Files skipped from review as they are similar to previous changes (4) * 16-3.5.0alpha2/alpine/Dockerfile * 17beta2-3.5.0alpha2/alpine/Dockerfile * README.md * update.sh
Additional context used
Learnings (1)
Common learnings
``` Learnt from: Komzpa PR: postgis/docker-postgis#386 File: 17-beta/initdb-postgis.sh:9-11 Timestamp: 2024-07-15T10:46:13.298Z Learning: In the `docker-postgis` repository, the `psql` variable is set in the parent official Postgres docker image and does not need to be assigned in the `initdb-postgis.sh` script. ```
Additional comments not posted (2)
Dockerfile.alpine.template (1)
`4-4`: **Verify compatibility and test the changes with the updated base image.** The base image version has been updated from `postgres:%%PG_MAJOR%%-alpine3.18` to `postgres:%%PG_MAJOR%%-alpine3.20`. Ensure that the new base image is compatible with all dependencies and thoroughly test the changes to confirm that no new issues are introduced.
15-3.4/alpine/Dockerfile (1)
`4-4`: **Verify compatibility and test the changes with the updated base image.** The base image version has been updated from `postgres:15-alpine3.18` to `postgres:15-alpine3.20`. Ensure that the new base image is compatible with all dependencies and thoroughly test the changes to confirm that no new issues are introduced.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
phillipross commented 3 months ago

@thomasboussekey thanks for your contribution! Please ignore the coderabbit review for now, we're just testing it 😅

ImreSamu commented 3 months ago

Hi @thomasboussekey ,

Thank you for the PR!

I have made some changes to the PR:

After reviewing the PR, I added other changes, such as the postgis 3.5.0alpha2 test images, and updated Alpine to 3.20.

So now we have three new images:

@phillipross :