Closed thomasboussekey closed 1 month ago
@thomasboussekey thanks for your contribution! Please ignore the coderabbit review for now, we're just testing it π
Hi @thomasboussekey ,
Thank you for the PR!
I have made some changes to the PR:
17beta2-master
directory.github/workflows/main.yml
and README.md
./update.sh
to regenerate the Dockerfiles from the templateAfter reviewing the PR, I added other changes, such as the postgis 3.5.0alpha2
test images, and updated Alpine to 3.20.
So now we have three new images:
postgis/postgis:17beta2-master
postgis/postgis:16-3.5.0alpha2-alpine
postgis/postgis:17beta2-3.5.0alpha2-alpine
@phillipross :
Walkthrough
## Walkthrough The changes introduce a robust multi-stage Docker build process for creating a PostgreSQL image with enhanced PostGIS extensions. Key dependencies and libraries are installed, along with scripts for initializing and updating PostGIS within PostgreSQL databases. These improvements streamline the setup and maintenance of spatial database environments, ensuring a smoother experience for users. ## Changes | File | Change Summary | |------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `17-beta/Dockerfile` | Implements a multi-stage build process based on `postgres:17beta2-alpine3.20`, installing dependencies and building libraries like CGAL, SFCGAL, PROJ, GEOS, and PostGIS. | | `17-beta/initdb-postgis.sh` | Introduces a script to automate the creation of a `template_postgis` database and load PostGIS extensions into specified databases. | | `17-beta/update-postgis.sh` | Adds a script that updates PostGIS extensions in specified databases, managing PostGIS and its dependencies effectively. | | `17beta2-3.5.0alpha2/alpine/Dockerfile` | Configures a Docker image for PostGIS 3.5.0alpha2 on Alpine Linux, including dependency installation, building PostGIS, and copying initialization scripts. | | `README.md` | Updates versioning information and adds new Docker image entries for PostGIS. | | `update.sh` | Introduces new entries for additional versions in associative arrays without altering existing logic. | | `12-3.4/alpine/Dockerfile` | Updates base image from `postgres:12-alpine3.18` to `postgres:12-alpine3.20`. | | `13-3.4/alpine/Dockerfile` | Updates base image from `postgres:13-alpine3.18` to `postgres:13-alpine3.20`. | | `14-3.4/alpine/Dockerfile` | Updates base image from `postgres:14-alpine3.18` to `postgres:14-alpine3.20`. | | `15-3.4/alpine/Dockerfile` | Updates base image from `postgres:15-alpine3.18` to `postgres:15-alpine3.20`. | | `16-3.4/alpine/Dockerfile` | Updates base image from `postgres:16-alpine3.18` to `postgres:16-alpine3.20`. | | `16-3.5.0alpha2/alpine/Dockerfile` | Introduces a new Dockerfile for PostGIS 3.5.0alpha2 with PostgreSQL 16 on Alpine, including relevant metadata and scripts. | | `Dockerfile.alpine.template` | Modifies the base image to `postgres:%%PG_MAJOR%%-alpine3.20` for a PostgreSQL setup template. | ## Poem > In the Docker depths, PostGIS lights, > PostgreSQL gains new heights. > Scripts to set the GIS scene, > Update, setup, all pristine. > Dependencies built with care, > Now your dataβs everywhere! ππRecent review details
**Configuration used: CodeRabbit UI** **Review profile: CHILL**Commits
Files that changed from the base of the PR and between 8a0cbf9bcc303e990d0bca4e35c813fd0b4f3071 and 42d811c4d0e15c4ea6c99413f61b8713932a3e4e.Files selected for processing (10)
* 12-3.4/alpine/Dockerfile (1 hunks) * 13-3.4/alpine/Dockerfile (1 hunks) * 14-3.4/alpine/Dockerfile (1 hunks) * 15-3.4/alpine/Dockerfile (1 hunks) * 16-3.4/alpine/Dockerfile (1 hunks) * 16-3.5.0alpha2/alpine/Dockerfile (1 hunks) * 17beta2-3.5.0alpha2/alpine/Dockerfile (1 hunks) * Dockerfile.alpine.template (1 hunks) * README.md (2 hunks) * update.sh (3 hunks)Files skipped from review due to trivial changes (4)
* 12-3.4/alpine/Dockerfile * 13-3.4/alpine/Dockerfile * 14-3.4/alpine/Dockerfile * 16-3.4/alpine/DockerfileFiles skipped from review as they are similar to previous changes (4)
* 16-3.5.0alpha2/alpine/Dockerfile * 17beta2-3.5.0alpha2/alpine/Dockerfile * README.md * update.shAdditional context used
Learnings (1)
Additional comments not posted (2)
Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Tips
### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit