search

postgis / postgis-java

java bindings for postgis
149 stars 56 forks source link

Register `net.postgis.jdbc.DriverWrapper` via `java.sql.Driver` service #100

Closed soc closed 3 years ago

soc commented 3 years ago

Should address https://github.com/postgis/postgis-java/issues/90, @OrangeDog, can you confirm?

soc commented 3 years ago

I verified that the file ends up in the right place in the jar file, but I'm currently too short on time to do more .:-/

soc commented 3 years ago

@OrangeDog Just wondering, wouldn't we need to also add an entry for DriverWrapperLW?

OrangeDog commented 3 years ago

DriverManager.getDriver("jdbc:postgresql_postGIS:/") would probably be the test.

phillipross commented 3 years ago

An automated test would be best. Thanks!

soc commented 3 years ago

@OrangeDog Ping?

OrangeDog commented 3 years ago

Hello? What are you expecting me to do?

soc commented 3 years ago

@OrangeDog Just wondering, wouldn't we need to also add an entry for DriverWrapperLW?

OrangeDog commented 3 years ago

I have no idea.

soc commented 3 years ago

Ok, thanks!

soc commented 3 years ago

@phillipross I registered all three drivers and added a test to verify that loading them works. Does this look good to you?

phillipross commented 3 years ago

@phillipross I registered all three drivers and added a test to verify that loading them works. Does this look good to you?

Yes, this looks good to me. Could I ask you to add a bit of javadoc to the test class to explain what it's testing? Thanks!

soc commented 3 years ago

Done!

phillipross commented 3 years ago

Thanks @soc for the code contribution and thanks @OrangeDog for filing the issue!