postgres-plr / plr

PL/R - R Procedural Language for PostgreSQL
GNU General Public License v2.0
123 stars 27 forks source link

Test and Build PL/R on PostgreSQL 14 #123

Closed AndreMikulec closed 1 year ago

AndreMikulec commented 3 years ago

Dave,

I did build using PostgreSQL 14:

To Appveyor (Windows builds)

To Github Actions (Linux builds)

Today https://github.com/postgres-plr/plr/compare/master...AndreMikulec:master_pg_REL_14_0_plr_REL8_4_4

Final Appveyor https://ci.appveyor.com/project/AndreMikulec/plr/builds/40989829

Final Github Actions https://github.com/AndreMikulec/plr/runs/3769652863

Shall I squash, re-test and re-build, and then create a pull request?

davecramer commented 2 years ago

@AndreMikulec

Sorry I didn't see this until now, yes please

Also I see that R has released 4.2.0 and 4.1.3

At the very least we should update to 4.1.3 and see if it builds on 4.2.0

AndreMikulec commented 2 years ago

@davecramer

Two weeks ago, I tested on R 4.2.0.

pg master and pg 14 (both with R 4.2.0) on both msvc and msys2. (Cygwin default pg and default R) https://github.com/AndreMikulec/plr/blob/master_andre/appveyor.yml#L69

Run results were all successful. https://ci.appveyor.com/project/AndreMikulec/plr/builds/43407600

At the very least we should update to 4.1.3 and see if it builds on 4.2.0 I will modify/add those two items to my copy of the postgres-plr master appveyror build. I will remove pg 9.5 and add pg 14 to my copy of the the postgres-plr master Github Actions build.

Within 7 days I plan to work on that. I plan to send to postgres-plr master a pull request.

davecramer commented 2 years ago

@davecramer

Two weeks ago, I tested on R 4.2.0.

pg master and pg 14 (both with R 4.2.0) on both msvc and msys2. (Cygwin default pg and default R) https://github.com/AndreMikulec/plr/blob/master_andre/appveyor.yml#L69

Run results were all successful. https://ci.appveyor.com/project/AndreMikulec/plr/builds/43407600

At the very least we should update to 4.1.3 and see if it builds on 4.2.0 I will modify/add those two items to my copy of the postgres-plr master appveyror build. I will remove pg 9.5 and add pg 14 to my copy of the the postgres-plr master Github Actions build.

Within 7 days I plan to work on that. I plan to send to postgres-plr master a pull request.

Awesome! Thanks I'll look out for it.

AndreMikulec commented 2 years ago

The pull request changes: https://github.com/postgres-plr/plr/commit/fb5d48e85e7147e018ef90c73f6b02288502fa89

A "better view" of the changes:

appveyor.yml (click to open in a new web page) https://github.com/postgres-plr/plr/blob/fb5d48e85e7147e018ef90c73f6b02288502fa89/appveyor.yml#L11

and

build.yml (click to open in a new web page) https://github.com/postgres-plr/plr/blob/fb5d48e85e7147e018ef90c73f6b02288502fa89/.github/workflows/build.yml#L51

The successful Job and Builds https://ci.appveyor.com/project/davecramer/plr-daun5/builds/43578035

Fixes Issue https://github.com/postgres-plr/plr/issues/123 Fixes Issue https://github.com/postgres-plr/plr/issues/134

Note, I forgot to increment the year in Joe's license in the README.md It is still at "2021".

https://github.com/postgres-plr/plr/blob/fb5d48e85e7147e018ef90c73f6b02288502fa89/README.md Copyright (c) 2003-2021 by Joseph E. Conway ALL RIGHTS RESERVED

One may want to increment.