Open devrimgunduz opened 1 month ago
sure, thanks for the report
@devrimgunduz
Dave is building every day using the pg "master". How exactly are you trying to build plr?
plr/.github/workflows/build.yml uses pg master https://github.com/davecramer/plr/blob/release_17/.github/workflows/build.yml#L25C10-L25C34
git clone --depth=1 https://github.com/postgres/postgres.git
Job https://github.com/davecramer/plr/actions/runs/10161280166/job/28099428293#step:5:28
# using postmaster on Unix socket, default port
ok 1 - plr 1985 ms
ok 2 - bad_fun 126 ms
ok 3 - opt_window 128 ms
ok 4 - do 125 ms
ok 5 - out_args 127 ms
ok 6 - plr_transaction 147 ms
ok 7 - opt_window_frame 128 ms
1..7
# All 7 tests passed.
The Job workflow file https://github.com/davecramer/plr/actions/runs/10161280166/workflow
The Job workflow file uses pg master https://github.com/davecramer/plr/actions/runs/10161280166/workflow#L31
git clone --depth=1 https://github.com/postgres/postgres.git
Can you build in the same way as the workflow file? Next, can you build using pg 17 beta2? One needs to replace
git clone --depth=1 https://github.com/postgres/postgres.git
with
git clone --branch REL_17_BETA2 --depth=1 https://github.com/postgres/postgres.git
Compare?
@AndreMikulec He needs a tag to build off of, we need to release 8_4_7 which is why I was trying to get CI to build clean.
I think we can release and fix it later. Most of the CI is succeeding.
Thoughts ?
Dave,
What is being done about 8_4_7? I did not see any plr C code changes here except pg versions and file renaming. https://github.com/davecramer/plr/commits/release_17/
Within a week, I will try to make a pull request. based off (but actually from my online clone of postgres-plr):
https://github.com/AndreMikulec/plr/tree/July_2024_updated_builds and SOME successful 17 recent actions https://github.com/AndreMikulec/plr/actions
There are no code changes other than versioning and sql files. So really I can back out any changes to CI and just merge that and tag it. I'm OK with the current failing tests.
@devrimgunduz
REL17 had built here on ubuntu x64. https://github.com/postgres-plr/plr/actions/runs/10238114376/job/28322183597
@devrimgunduz, please verify, and if successful one may close the issue.
Hi,
8.4.6 fails to build against PostgreSQL 17. v17 beta2 is already out. Can you please take a look?
Thanks, Devrim