search

postgresml / pgcat

PostgreSQL pooler with sharding, load balancing and failover support.
MIT License
3.14k stars 195 forks source link

tag container with release tags #484

Open DeoLeung opened 1 year ago

DeoLeung commented 1 year ago

Hi,

It will be better if the container could be tagged using the release tags, it will be much more easy to find target versions.

sebastianwebber commented 1 year ago

@levkk what do you think about pushing the builds only in the main tag and all tags?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

the config in build-and-push.yaml will be something like this:

# ...
on:
  push:
    branches:    
      - main
    tags:
      - v*

Let me know if you agree so I can send another PR.

levkk commented 1 year ago

That works I think.

sebastianwebber commented 1 year ago

there we go: https://github.com/postgresml/pgcat/pull/508

sebastianwebber commented 1 year ago

Before closing this issue, do you think that it will be nice to add a goreleaser config file to automatically generate a release when a new tag is created?

sebastianwebber commented 1 year ago

@levkk I noticed that you merged my PR. It worked for the main branch, is the case to create a new tag to validate it? Something like v1.0.1 should work.

levkk commented 1 year ago

Will test it out as soon as I can release the next version. Probably early next week, we're overdue for a release!