postgrespro / pg_probackup

Backup and recovery manager for PostgreSQL
https://postgrespro.github.io/pg_probackup/
Other
704 stars 86 forks source link

[PBCKP-354] Pg15: continue reading if error "missing contrecord" is met. #576

Closed funny-falcon closed 1 year ago

funny-falcon commented 1 year ago

Pg15 now reports if it didn't met expected contrecord. Absence of this message was long standing bug in previous postgres versions.

This situation could happen if WAL segment was rewritten after restart.

It causes "tests.validate.ValidateTest.test_validate_wal_unreal_values" to hang but (looks like) for other reason: test tries to read "in future".

Probably we should stop reading logs here. But since we always did continue here, lets continue as well.