postgrespro / pg_wait_sampling

Sampling based statistics of wait events
Other
147 stars 35 forks source link

About the default value of pg_wait_sampling.profile_queries #34

Closed kasaharatt closed 2 years ago

kasaharatt commented 3 years ago

Hi.

README says that defaul value of "pg_wait_sampling.profile_queries' is flase. However, the actual default value seems to be true. It looks like it probably need to do the following code modification.

@@ -223,7 +223,7 @@ setup_gucs()
        if (!profile_queries_found)
                DefineCustomBoolVariable("pg_wait_sampling.profile_queries",
                                "Sets whether profile should be collected per query.", NULL,
-                               &collector_hdr->profileQueries, true,
+                               &collector_hdr->profileQueries, false,
                                PGC_SUSET, 0, shmem_bool_guc_check_hook, NULL, NULL);

        if (history_size_found

regards,

keremet commented 2 years ago

Fixed. https://github.com/postgrespro/pg_wait_sampling/commit/a9109e6693d5c49115725ff8f2ad8c176ca5f11c