search

postgrespro / pg_wait_sampling

Sampling based statistics of wait events
Other
147 stars 35 forks source link

postgres 15 support #54

Closed RekGRpth closed 2 years ago

RekGRpth commented 2 years ago

postgres 15 support

this fixes https://github.com/postgrespro/pg_wait_sampling/issues/53

maksm90 commented 2 years ago

This change was induced by recent change in commit https://github.com/postgres/postgres/commit/ce3049b0215b63744d11c0ce3ac6afdb67fc2ff0 .

Generally LGTM. But @RekGRpth could you take multiple calls of InitPostgres() away to compat.c where all these calls are hidden under unified name with _compat suffix.

RekGRpth commented 2 years ago

This change was induced by recent change in commit postgres/postgres@ce3049b .

No, but this https://github.com/postgres/postgres/commit/31ed3cf746a61538876c66a778ec8a372a3b4ffb

RekGRpth commented 2 years ago

could you take multiple calls of InitPostgres() away to compat.c where all these calls are hidden under unified name with _compat suffix.

done

maksm90 commented 2 years ago

No, but this https://github.com/postgres/postgres/commit/31ed3cf746a61538876c66a778ec8a372a3b4ffb

Yes, I had erroneously copy-pasted the link.

@shinderuk after fixing of my note PR might be merged.

shinderuk commented 2 years ago

Merged after squashing and adding a missing include. Thank you!

df7cb commented 2 years ago

Hi, PG 15.0 is due in two weeks, could you please tag a new pg_wait_sampling release so we can update the packages? Thanks!

maksm90 commented 2 years ago

Hi, PG 15.0 is due in two weeks, could you please tag a new pg_wait_sampling release so we can update the packages?

Hi, sure! You might track the progress in https://github.com/postgrespro/pg_wait_sampling/issues/59 Thanks for notice.