Closed jmscott closed 2 years ago
Fixed compatibility with PG14. Big thanks for reporting!
thanks. all our tests are passing.
-j
On Fri, Oct 8, 2021 at 5:14 AM pashkinelfe @.***> wrote:
Closed #101 https://github.com/postgrespro/rum/issues/101.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/postgrespro/rum/issues/101#event-5433773325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK2YKELTSXNTKKIU75HBG3UF2767ANCNFSM5FSXQILA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Fast is fine, But accuracy is final. You must learn to be slow in a hurry.
compiling against pg14.0, getting the following error on both mac big sur and linux 4.18.0-240.15.1.el8_3.x86_64.
src/rumutil.c:136:22: warning: incompatible function pointer types assigning to 'aminsert_function' (aka 'bool ()(struct RelationData , unsigned long , bool , struct ItemPointerData , struct RelationData , enum IndexUniqueCheck, bool, struct IndexInfo )') from 'bool (Relation, Datum , bool , ItemPointer, Relation, IndexUniqueCheck, struct IndexInfo )' (aka 'bool (struct RelationData , unsigned long , bool , struct ItemPointerData , struct RelationData , enum IndexUniqueCheck, struct IndexInfo )') [-Wincompatible-function-pointer-types] amroutine->aminsert = ruminsert; ^
~~~~~