search

postgresql-interfaces / psqlodbc

Other
16 stars 13 forks source link

Key caches based on software versions #13

Closed apgrucza closed 5 months ago

apgrucza commented 5 months ago

This fixes the problem of the cache action incorrectly causing steps to be skipped when software versions are updated.

Note that changing the commands inside a step will not prevent that step from being skipped, but this should not be a problem once the workflow is stable. If this does occur, it can be resolved by adding a suffix to the cache key to force the creation of a new cache.

apgrucza commented 5 months ago

The failed workflow was due to this bug in actions/cache. I've renamed the necessary cache key to work around it.

davecramer commented 5 months ago

testing failed ?

apgrucza commented 5 months ago

testing failed ?

See my comment above. Please rerun the workflow.

davecramer commented 5 months ago

I noticed that you changed it so that we aren't downloading openssl64 anymore. We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions EDB has version 3.0.13 of openssl

apgrucza commented 5 months ago

I noticed that you changed it so that we aren't downloading openssl64 anymore. We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions EDB has version 3.0.13 of openssl

@davecramer Yes, I was expecting you to merge those changes from your fork, which I see you've now done. After your changes, the other caching problem I mentioned in the description of #13 has occurred and prevented the build of PostgreSQL, resulting in missing DLLs again. So I've created a new PR to address that here: #19