Problems setting the Options object

[revelt]

I'm working with email templates, which have to be in XHTML, so I need closing slashes on single tags.

However, when I set the options object:

var options = { closingSingleTag: 'slash' }

and use it:

.pipe(posthtml(plugins, options))

all my closing slashes are still removed. I raised and later closed an issue with PostHTML regarding this — it's not caused by PostHTML since its unit tests prove the settings do work.

I don't see any unit tests covering settings actually working.

Can somebody investigate, is it actually possible to set the closingSingleTag in gulp-posthtml?

thank you.

[michael-ciniawsky]

@revelt This one is my nemesis atm :) Jesus Christ..., there is something buggy in general 'somewhere', could you post your Gulp Config please and log the options {Object} out? (Otherwise please provide a test repo so I can do it myself 😛)

[Scrum]

@revelt Hi, this PR must closed this bug.

[revelt]

@GitScrum but it's not merged in yet, isn't it? should I wait until it's merged to 100% confirm?

[Scrum]

@revelt yep.

[revelt]

OK. If you guys see it's working feel free to close yourselves. I got fed up with this months ago and stopped using PostHTML completely. On the positive side, it made me produce quite few libs on npm.

[Scrum]

@revelt try

[revelt]

OK, I set it up again, no luck. Same as before, all slashes are still removed from all img tags.

I'm using { closingSingleTag: 'slash' } as options object. Maybe it's available only in posthtml-render where I took it from?

[revelt]

By the way I can't fulfil @michael-ciniawsky request and share Gulp settings since it's closed source.

I mean, if anybody's using gulp-posthtml, just try flipping your own Gulp plugin settings, to export singleton HTML tags with and then without the closing slashes. See what happens, see if you can get it working. Because I can't :(

var options = { closingSingleTag: 'slash' }

[Scrum]

@revelt i work on this, don't worry.

[Scrum]

@revelt Hi, i create demo and this work for me. Show me you case.

[revelt]

The test is missing plugins, that's where the trouble happens. I'll fork and supplement the demo with a plugin and some CSS via PR. Is that all right?

[Scrum]

Yep.

[revelt]

Done. Thanks for looking into this. The plugins seem the be "not seeing" the config, img is rendered without a slash in both cases after plugin processes the HTML.

[Scrum]

Thanks, I will investigate this.

[Scrum]

You lost actuar tree after call render. I create PR which fixed this

[revelt]

Aha! My bad. Thank you very much. Closing this.