search

posthtml / posthtml-expressions

Use variables, JS-like expressions, and even markup-powered logic in your HTML.
Other
123 stars 20 forks source link

Fix regex generated for special characters #159

Closed jbreton closed 11 months ago

jbreton commented 11 months ago

157 introduced a bug resulting in an invalid regex if custom delimiters are starting with a regex special character.

jbreton commented 11 months ago

How relevant are those checks ? Node 14 reached EOL 3 years and 6 months ago and security patches 6 months ago ? I don't see how my changes could cause these failures 😕

cossssmin commented 11 months ago

Hey, thanks for working on this!

I don't think it's the Node versions and it's definitely not your code, something's wrong with NPM in GitHub Actions.

@Scrum any ideas as to why this may be happening?

npm ERR! Cannot read property 'fclone' of undefined

This makes me think it can't read the package.json so dependencies key does not exist.

Scrum commented 11 months ago

Yes, I accidentally updated the lock file to version 3, I'll fix it now

Scrum commented 11 months ago

@jbreton rebase to master please.

jbreton commented 11 months ago

@Scrum rebase done 👍🏻

Scrum commented 11 months ago

@jbreton publish 1.11.3

jbreton commented 11 months ago

@Scrum @cossssmin Awesome! thank you