posthtml / posthtml-expressions

Use variables, JS-like expressions, and even markup-powered logic in your HTML.
Other
123 stars 20 forks source link

Milestone 1.4.3 #87

Closed Scrum closed 4 years ago

Scrum commented 4 years ago

Proposed Changes

https://github.com/posthtml/posthtml-expressions/issues/82

Types of Changes

What types of changes does your code introduce Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is a reminder of what we are going to look for before merging your code.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.1%) to 97.015% when pulling 13a67d19028eaef766f70a1a68a59a582fd63b95 on milestone-1.4.3 into b351d16e02a751c357404691677578aafb613cdb on master.

cossssmin commented 4 years ago

Just realized that this won't work:

<if condition="foo === 'bar'">
  <raw>
    {{ foo }}
  </raw>
  <p class="@{{ dynamicClass }}">{{ foo }}</p>
</if>

It does not ignore @{{ dynamicClass }} and results in <p class="undefined">bar</p>. Any ideas?

cossssmin commented 4 years ago

Added a test for <raw> in the <switch> tag, since that was problematic as well. Not sure what to do with the issue from my comment above, but I am ok with merging/releasing 1.4.3 and handling it later.

We could actually tackle #88 right after this, I already fixed the issue locally and am waiting on this one to be merged first. Or, should I make #88 part of this milestone, what do you prefer?

Scrum commented 4 years ago

We could actually tackle #88 right after this, I already fixed the issue locally and am waiting on this one to be merged first. Or, should I make #88 part of this milestone, what do you prefer?

Without a doubt it is better to take after merge this branch

Scrum commented 4 years ago

@cossssmin publish v1.4.3