Closed Scrum closed 4 years ago
Just realized that this won't work:
<if condition="foo === 'bar'">
<raw>
{{ foo }}
</raw>
<p class="@{{ dynamicClass }}">{{ foo }}</p>
</if>
It does not ignore @{{ dynamicClass }}
and results in <p class="undefined">bar</p>
. Any ideas?
Added a test for <raw>
in the <switch>
tag, since that was problematic as well. Not sure what to do with the issue from my comment above, but I am ok with merging/releasing 1.4.3 and handling it later.
We could actually tackle #88 right after this, I already fixed the issue locally and am waiting on this one to be merged first. Or, should I make #88 part of this milestone, what do you prefer?
We could actually tackle #88 right after this, I already fixed the issue locally and am waiting on this one to be merged first. Or, should I make #88 part of this milestone, what do you prefer?
Without a doubt it is better to take after merge this branch
@cossssmin publish v1.4.3
Proposed Changes
https://github.com/posthtml/posthtml-expressions/issues/82
Types of Changes
What types of changes does your code introduce Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is a reminder of what we are going to look for before merging your code.