search

posthtml / posthtml-url-parameters

Add parameters to URLs with PostHTML.
MIT License
3 stars 2 forks source link

Upgrade is-url-superb to 4.0.0 to fix a bug #2

Closed jaddison closed 4 years ago

jaddison commented 4 years ago

Problem

Described here in the Maizzle project; template variables in a URL break Maizzle's urlParameters functionality.

Environment

The Test + Fix

Looks like the fix is to upgrade is-url-superb from 3.0.0 to 4.0.0; this code returns false with 3.0.0, but true with 4.0.0 (I used repl.it):

require('is-url-superb')('https://example.com/{{ var }}')
cossssmin commented 4 years ago

Reopening this as it has not been actually solved, see failing test in https://github.com/posthtml/posthtml-url-parameters/commit/4c6994b9f8aea0ec57572c23a3ed8f1d67db65d7