search

postiffm / bibledit-desktop

Desktop version of Bibledit
GNU General Public License v3.0
4 stars 6 forks source link

Use GtkApplication and other new features #121

Closed rluzynski closed 4 years ago

rluzynski commented 4 years ago

Please review and accept.

rluzynski commented 4 years ago

There is something strange in this pull request, it seems to me that the commits have been reordered. However, in my repo https://github.com/rluzynski/bibledit-desktop/commits/gtk3 the order looks correct to me. Most of the time the order of commits does not matter but the commit Do not use and do not distribute the old icon mentions the previous commit which should be New icons. If it is reordered then the previous commit does not mean what I wanted to say.

postiffm commented 4 years ago

Here is what my current tree looks like---so you can see the order of commits, with the original gtk3 branch on the bottom (oldest on bottom, in other words).

3af5dc7 (HEAD -> rluzynski-gtkapplication4) Merge branch 'gtk3' of https://github.com/rluzynski/bibledit-desktop into rluzynski-gtkapplication4 7d718e6 [WIP] Application menu added 22920d7 [WIP] Port to GtkApplication framework d6db43f [WIP] New icons 4818a80 (origin/gtk3, gtk3) Bump the required version of glib2.

postiffm commented 4 years ago

And now after I pulled the latest:

91fefcf (HEAD -> rluzynski-gtkapplication5) Merge rluzynski's 4 commits that implement GtkApplication. a7118b2 Application menu added. fcb2df4 Port to GtkApplication framework. 0360aeb Do not use and do not distribute the old icon. b7f13bc New icons. 4818a80 (origin/gtk3, gtk3) Bump the required version of glib2. 463c9d4 CSS: Apply rounded top corners to the floating window

postiffm commented 4 years ago

This all is integrated into the gtk3 branch.