search

postiffm / bibledit-desktop

Desktop version of Bibledit
GNU General Public License v3.0
4 stars 6 forks source link

Rework the system log window into a regular window. #125

Closed rluzynski closed 5 years ago

rluzynski commented 5 years ago

Some remarks for @postiffm:

  1. You may squash the second commit with the first one if you totally agree with it.
  2. You may reject the second commit if you don't agree.
  3. You may leave and accept as is, this will work fine, too.
  4. This pull request could be backported to master (with GTK2) with just a minor effort. I open this pull request against gtk3 because I have used few GTK3-specific functions.
postiffm commented 5 years ago

Wow! Great. I will take a look. We'll keep it on the gtk3 branch only to make it easier. I just did a quick code review--I like what I see.

postiffm commented 5 years ago

@rluzynski this seems to work nicely. I like that the Esc key closes it. Nice touch. With the dialog open, when I do some simple navigations, I often see two of these errors: "GtkDialog mapped without a transient parent. This is discouraged." I understand the point, but I have no dialog boxes open now. The system log is now a window, not a dialog, so I don't understand what could be happening.

postiffm commented 5 years ago

This is integrated now in 22ff675.

rluzynski commented 5 years ago

@postiffm:

With the dialog open, when I do some simple navigations, I often see two of these errors: "GtkDialog mapped without a transient parent. This is discouraged." I understand the point, but I have no dialog boxes open now. The system log is now a window, not a dialog, so I don't understand what could be happening.

It's surprising for me, too. We have been working on removing these issues in May 2018. Maybe something remains around but I'm not aware of these cases. My suggestion is to run under a debugger and put a breakpoint at the line (in the GTK source code) which displays this message.