search

postiffm / bibledit-desktop

Desktop version of Bibledit
GNU General Public License v3.0
4 stars 6 forks source link

The correct way to add icons #128

Open rluzynski opened 5 years ago

rluzynski commented 5 years ago

Please do not merge this pull request literally. Since the gtk3 branch is a development branch and rewriting history is allowed, my suggestion is:

  1. The first commit Fixup for "New icons." should be squashed into the older commit New icons. This should make some unnecessary files just disappear without any trace instead of being created by one commit and then deleted by another one.
  2. The second commit Revert "Update makefile for pixmap" could be squashed into the original Update makefile for pixmap but this would make the commit disappear. Instead of this it is OK to just drop both the original commit and the revert.

This fixup is inspired by the article http://ptomato.name/advanced-gtk-techniques/html/desktop-file.html.

postiffm commented 5 years ago

@rluzynski Sorry for the delay in looking at this. I am extremely busy right now, so this might sit for a while. I think I am understanding what you want to do with this.

postiffm commented 4 years ago

I lost track of this very badly. Sorry. Is it still relevant?