postiffm / bibledit-desktop

Desktop version of Bibledit
GNU General Public License v3.0
4 stars 6 forks source link

Gtk3 #71

Closed rluzynski closed 5 years ago

rluzynski commented 5 years ago

This is a port of the styling of floating windows to GTK3 with CSS.

Feel free to complain and/or request changes. For example, you may request to squash these two commits (or you may squash them on your own) but I think that splitting changes into two commits improves readability and separates using CSS in general from using CSS to style the floating window.

postiffm commented 5 years ago

Looks good on initial read. This CSS+GTK stuff is all new for me, so I'm looking forward to learning.

postiffm commented 5 years ago

Here is the log:

af3bcea (HEAD -> gtk3, origin/gtk3) Merge branch 'rluzynski-pull12162018' into gtk3
fd2c130 (rluzynski-pull12162018) Merge branch 'gtk3' of https://github.com/rluzynski/bibledit-desktop into rluzynski-pull12162018

It would be nice if the log wouldn't show these merge commits but would instead show what you actually did, that is, YOUR log message. How can we accomplish that?

I have these two settings in my .gitconfig:

[branch]
    autosetuprebase = always
[merge]
    ff = false