postiffm / bibledit-desktop

Desktop version of Bibledit
GNU General Public License v3.0
4 stars 6 forks source link

Backup restoration fails #8

Closed postiffm closed 7 years ago

postiffm commented 7 years ago

File | Restore did not work on Windows.

postiffm commented 7 years ago

I figured out the problem was that the spawn progress window logic was messed up. It was asking for async mode to let the program run on, but it wanted to show progress, so it had to wait until the program was finished. These are conflicting instructions that were set in a helper function called gwrappers.cpp::GwSpawn::progress. The logic inside of gwrappers.cpp GwSpawn::run (WIN32 version of the function) would try to grab the return value of an async thread before the thread was finished. As a result, it would cut off the tar unpack function at some time shortly after it started. I re-did the logic there, and it seems better.