search

postlight / hubot-spotify-playlist

Allows the ability to add/remove/findTracks to a Spotify Playlist.
8 stars 8 forks source link

Change from robot.hear to robot.listen #12

Open ajc308 opened 8 years ago

ajc308 commented 8 years ago

Please change robot.hear to robot.listen in these 4 instances: https://github.com/postlight/hubot-spotify-playlist/blob/master/src/spotify-playlist.coffee#L124-L133.

Since this is using robot.hear, when I run the bot locally (even with a different name), it responds to text matches regardless of the preceding name.

robot.hear - callback is called anytime a message's text matches robot.respond - callback is only called for messages that are immediately preceded by the robot's name or alias

Hear vs. listen: https://github.com/github/hubot/blob/master/docs/scripting.md#hearing-and-responding

I tried to submit a PR for this myself but was denied due to permissions.

mutewinter commented 8 years ago

Write access granted.