search

postlight / lux

Build scalable, Node.js-powered REST JSON APIs with almost no code.
https://lux.postlight.com
MIT License
570 stars 60 forks source link

feat: enable rollup cache feature #700

Closed nickschot closed 7 years ago

nickschot commented 7 years ago

Enabling the rollup cache feature improves subsequent builds by ~3-3.5 times on my quick test (~6.5 seconds to ~1.9 seconds).

See: https://github.com/rollup/rollup/wiki/JavaScript-API for more info

Tracking issue: #701

nickschot commented 7 years ago

Not sure yet if we want this enabled in production. What do you think @zacharygolba ?

Edit: the watcher seems disabled on production, so it shouldnt cause any issues (apart from taking memory, so we might still want to disable it in production)

codecov[bot] commented 7 years ago

Codecov Report

Merging #700 into master will decrease coverage by 0.04%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #700      +/-   ##
=========================================
- Coverage   92.44%   92.4%   -0.05%     
=========================================
  Files         180     180              
  Lines        2012    2014       +2     
=========================================
+ Hits         1860    1861       +1     
- Misses        152     153       +1
Impacted Files Coverage Δ
src/packages/compiler/index.js 84% <50%> (-2.96%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73bb9d1...27db2fc. Read the comment docs.