postlight / lux

Build scalable, Node.js-powered REST JSON APIs with almost no code.
https://lux.postlight.com
MIT License
571 stars 60 forks source link

style: no more semi colons! #706

Closed zacharygolba closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #706 into master will increase coverage by 0.04%. The diff coverage is 89.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   90.28%   90.33%   +0.04%     
==========================================
  Files         194      194              
  Lines        2090     2090              
  Branches      430      430              
==========================================
+ Hits         1887     1888       +1     
+ Misses        181      180       -1     
  Partials       22       22
Impacted Files Coverage Δ
...kages/router/route/params/parameter-group/index.js 94.44% <ø> (ø) :arrow_up:
...outer/route/params/errors/parameter-value-error.js 100% <ø> (ø) :arrow_up:
src/packages/response/constants.js 100% <ø> (ø) :arrow_up:
src/packages/router/route/params/index.js 100% <ø> (ø) :arrow_up:
...rc/packages/router/route/params/parameter/index.js 100% <ø> (ø) :arrow_up:
...es/database/query/errors/record-not-found-error.js 100% <ø> (ø) :arrow_up:
src/packages/loader/builder/index.js 0% <ø> (ø) :arrow_up:
src/packages/logger/request-logger/index.js 25% <ø> (ø) :arrow_up:
src/packages/logger/utils/line.js 100% <ø> (ø) :arrow_up:
...finitions/context/utils/create-definition-group.js 100% <ø> (ø) :arrow_up:
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4be531...3e1ed45. Read the comment docs.

jamemackson commented 7 years ago

why??

zacharygolba commented 7 years ago

@jamemackson It's something we've been doing internally at postlight and it feels pretty nice to give your pinky a break 😉