postlight / lux

Build scalable, Node.js-powered REST JSON APIs with almost no code.
https://lux.postlight.com
MIT License
570 stars 60 forks source link

fix: detailed error messages leak into production responses #713

Closed zacharygolba closed 7 years ago

zacharygolba commented 7 years ago

Closes #697

codecov[bot] commented 7 years ago

Codecov Report

Merging #713 into master will decrease coverage by 0.5%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   90.28%   89.78%   -0.51%     
==========================================
  Files         194      195       +1     
  Lines        2090     2094       +4     
  Branches      430      430              
==========================================
- Hits         1887     1880       -7     
- Misses        181      192      +11     
  Partials       22       22
Impacted Files Coverage Δ
src/packages/responder/utils/data-for.js 100% <100%> (ø) :arrow_up:
src/utils/env.js 100% <100%> (ø)
src/packages/database/model/index.js 91.66% <0%> (-7.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4817b26...a207959. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #713 into master will decrease coverage by 0.5%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   90.28%   89.78%   -0.51%     
==========================================
  Files         194      195       +1     
  Lines        2090     2094       +4     
  Branches      430      430              
==========================================
- Hits         1887     1880       -7     
- Misses        181      192      +11     
  Partials       22       22
Impacted Files Coverage Δ
src/utils/env.js 100% <100%> (ø)
src/packages/responder/utils/data-for.js 100% <100%> (ø) :arrow_up:
src/packages/database/model/index.js 91.66% <0%> (-7.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4817b26...a207959. Read the comment docs.