search

postlight / lux

Build scalable, Node.js-powered REST JSON APIs with almost no code.
https://lux.postlight.com
MIT License
570 stars 60 forks source link

migrate circle config to V2 format #732

Closed jamemackson closed 6 years ago

jamemackson commented 6 years ago

This PR migrates the existing circle CI logic to their V2 configuration format.

Fixes #731

jamemackson commented 6 years ago

@zacharygolba - the npm run flow step is failing with the following error:

#!/bin/bash --login
npm run flow

> lux-framework@1.2.2 flow /home/ubuntu/postlight/lux
> flow check

Fatal error: exception Not_found

the same command runs successfully locally as well as when I ssh into the circle build runner.

Do you have any ideas? I'm happy to do the leg work here but am out of ideas on how to address this.

zacharygolba commented 6 years ago

Hey @jamemackson thanks for the pull request! I took a stab at upgrading to circleci v2 a while back in the refactor-tech-debt branch and had some luck with this config.

jamemackson commented 6 years ago

Thanks @zacharygolba, I'll take a look at that this week :)

nickschot commented 5 years ago

@zacharygolba @jamemackson the config from that branch has the exact same issue. I am trying to see why it is failing. That exception Not_found is a very broad error message thrown by flow itself.